Skip to content

chore(cli-integ): fix a race condition in the resource-pool tests#32646

Merged
mergify[bot] merged 2 commits intomainfrom
huijbers/fix-race
Dec 23, 2024
Merged

chore(cli-integ): fix a race condition in the resource-pool tests#32646
mergify[bot] merged 2 commits intomainfrom
huijbers/fix-race

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Dec 23, 2024

There was a race condition between take1 and take2, and the tests would expect take1 to always win the race.

Change the test to force take1 to win.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
chore(cli-integ): fix a race condition in the resource-pool tests
5676b83 
There was a race condition between `take1` and `take2`, and the tests
would expect `take1` to always win the race.
@rix0rrr rix0rrr requested a review from a team as a code owner December 23, 2024 13:55
@github-actions github-actions bot added the p2 label Dec 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 23, 2024 13:55
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 23, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (a0525f5) to head (705c2e1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32646   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         106      106           
  Lines        6954     6954           
  Branches     1287     1287           
=======================================
  Hits         5601     5601           
  Misses       1175     1175           
  Partials      178      178
Flag Coverage Δ
suite.unit 80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.54% <ø> (ø)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 23, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 705c2e1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 5aec766 into main Dec 23, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the huijbers/fix-race branch December 23, 2024 14:57
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 23, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rix0rrr @aws-cdk-automation @iliapolo