chore(cli-integ): remove in-source compilation of 'bin' directory#32642
chore(cli-integ): remove in-source compilation of 'bin' directory#32642mergify[bot] merged 3 commits intomainfrom
Conversation
The CLI integ test package relies on the `bin` directory being compiled in-source. In new projen-managed setups, this is not common anymore. Remove the dependency.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32642 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 106 106
Lines 6954 6954
Branches 1287 1287
=======================================
Hits 5601 5601
Misses 1175 1175
Partials 178 178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
||
| <!-- BEGIN json --> | ||
| ```json | ||
| { |
There was a problem hiding this comment.
Doesn't seem related to the PR? is this intentional?
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The CLI integ test package relies on the
bindirectory being compiled in-source. In new projen-managed setups, this is not common anymore.Move the actual CLI sources into the
lib/clidirectory and launch them from there.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license