feat(ecs): ExternalService support daemon scheduling strategy#32630
feat(ecs): ExternalService support daemon scheduling strategy#32630mergify[bot] merged 14 commits intoaws:mainfrom
ExternalService support daemon scheduling strategy#32630Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32630 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 236 236
Lines 14253 14253
Branches 2490 2490
=======================================
Hits 11522 11522
Misses 2446 2446
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
wladyslawczyzewski
left a comment
There was a problem hiding this comment.
Thanks for this contribution! Could you please also add the daemon property to the ExternalService class as it done for Ec2Service?
|
Yeah, of course, I actually copied |
|
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
@mergify update |
✅ Branch has been successfully updated |
aaythapa
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
packages/@aws-cdk-testing/framework-integ/test/aws-ecs/test/external/integ.daemon-service.ts
Show resolved
Hide resolved
packages/aws-cdk-lib/aws-ecs/test/external/external-service.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Aayush thapa <84202325+aaythapa@users.noreply.github.com>
Pull request has been modified.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@mergify update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
Co-authored-by: Aayush thapa <84202325+aaythapa@users.noreply.github.com>
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32538
Description of changes
ExternalServicesupportdaemonscheduling strategyDescription of how you validated changes
Unit test
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license