Skip to content

chore: updating the PR template#32546

Merged
mergify[bot] merged 3 commits intomainfrom
moelasmar/update_pr_template
Dec 16, 2024
Merged

chore: updating the PR template#32546
mergify[bot] merged 3 commits intomainfrom
moelasmar/update_pr_template

Conversation

@moelasmar
Copy link
Copy Markdown
Contributor

Description of changes

Update the PR template to ask contributor to list the changes to any IAM or Resource policies.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2024 18:39
@github-actions github-actions bot added the p2 label Dec 16, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 16, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@moelasmar moelasmar changed the title chore: Updating the PR template chore: updating the PR template Dec 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review December 16, 2024 18:44

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.80%. Comparing base (fb030d6) to head (5233e09).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32546   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files         108      108           
  Lines        7159     7159           
  Branches     1319     1319           
=======================================
  Hits         5642     5642           
  Misses       1332     1332           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.80% <ø> (ø)

Co-authored-by: Samson Keung <keungsi@amazon.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5233e09
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 16, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d1bb1ca into main Dec 16, 2024
@mergify mergify bot deleted the moelasmar/update_pr_template branch December 16, 2024 20:07
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants