Skip to content

chore: print more information in Aspects proptest#32543

Merged
mergify[bot] merged 3 commits intomainfrom
huijbers/proptest-debugging
Dec 17, 2024
Merged

chore: print more information in Aspects proptest#32543
mergify[bot] merged 3 commits intomainfrom
huijbers/proptest-debugging

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Dec 16, 2024

We weren't printing which Aspects were there at the start of the tree, vs which Aspects were added during the Aspect run.

Print that info.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

We weren't printing which Aspects were there at the start of the tree,
vs which Aspects were added during the Aspect run.

Print that info.
@rix0rrr rix0rrr requested a review from a team as a code owner December 16, 2024 15:36
@aws-cdk-automation aws-cdk-automation requested a review from a team December 16, 2024 15:36
@github-actions github-actions bot added the p2 label Dec 16, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 16, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.85%. Comparing base (506d210) to head (639c5f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32543   +/-   ##
=======================================
  Coverage   78.85%   78.85%           
=======================================
  Files         108      108           
  Lines        7165     7165           
  Branches     1319     1319           
=======================================
  Hits         5650     5650           
  Misses       1330     1330           
  Partials      185      185           
Flag Coverage Δ
suite.unit 78.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.85% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 16, 2024
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended for this change to be only added in the unit test file?

@rix0rrr
Copy link
Copy Markdown
Contributor Author

rix0rrr commented Dec 17, 2024

Is it intended for this change to be only added in the unit test file?

Yes! It adds debug printing which will help debug occasional proptest errors.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 17, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 639c5f4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 537cabf into main Dec 17, 2024
@mergify mergify bot deleted the huijbers/proptest-debugging branch December 17, 2024 15:40
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants