fix(stepfunctions-tasks): `SageMakerCreateTrainingJob` add sagemaker:AddTags permission by phuhung273 · Pull Request #32536 · aws/aws-cdk

phuhung273 · 2024-12-16T11:15:50Z

Issue # (if applicable)

Closes #32294

Reason for this change

Missing permission

Description of changes

StepFunctions add sagemaker:AddTags permission

Description of how you validated changes

Unit + Integration test

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

codecov · 2024-12-16T11:29:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.17%. Comparing base (862072e) to head (0e51269).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #32536   +/-   ##
=======================================
  Coverage   82.17%   82.17%           
=======================================
  Files         119      119           
  Lines        6862     6862           
  Branches     1158     1158           
=======================================
  Hits         5639     5639           
  Misses       1120     1120           
  Partials      103      103

Flag	Coverage Δ
suite.unit	`82.17% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`∅ <ø> (∅)`
packages/aws-cdk-lib/core	`82.17% <ø> (ø)`

GavinZZ

Thank you for contribution!

mergify · 2025-02-20T21:47:48Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-20T21:47:53Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify · 2025-02-20T21:55:09Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

phuhung273 · 2025-02-21T08:11:33Z

@Mergifyio requeue

mergify · 2025-02-21T08:11:44Z

requeue

❌ Command disallowed due to command restrictions in the Mergify configuration.

Details

sender-permission >= write

…sion

Pull request has been modified.

mergify · 2025-02-21T17:58:10Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-02-21T17:58:15Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

mergify · 2025-02-21T18:02:10Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

GavinZZ · 2025-02-21T19:27:50Z

@Mergifyio requeue

mergify · 2025-02-21T19:27:56Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

mergify · 2025-02-21T19:28:32Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

…sion

Pull request has been modified.

aws-cdk-automation · 2025-02-21T20:08:01Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 0e51269
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-02-21T20:08:21Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-02-21T20:09:15Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

phuhung273 added 3 commits December 15, 2024 11:19

add IAM policy

afcb53f

train channel

d48700f

integ

159fce7

github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Dec 16, 2024

aws-cdk-automation requested a review from a team December 16, 2024 11:16

github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Dec 16, 2024

phuhung273 changed the title ~~Stepfunction createtrainingjob addtag permission~~ fix(stepfunctions-tasks): CreateTrainingJob add sagemaker:AddTag permission Dec 16, 2024

aws-cdk-automation previously requested changes Dec 16, 2024

View reviewed changes

phuhung273 changed the title ~~fix(stepfunctions-tasks): CreateTrainingJob add sagemaker:AddTag permission~~ fix(stepfunctions-tasks): SageMakerCreateTrainingJob add sagemaker:AddTag permission Dec 16, 2024

phuhung273 changed the title ~~fix(stepfunctions-tasks): SageMakerCreateTrainingJob add sagemaker:AddTag permission~~ fix(stepfunctions-tasks): SageMakerCreateTrainingJob add sagemaker:AddTags permission Dec 16, 2024

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 16, 2024

unit

4e2d47a

phuhung273 mentioned this pull request Dec 24, 2024

GHAS/CodeQL reporting missing input sanitization aws/aws-sdk-js-v3#6623

Closed

4 tasks

gracelu0 added the needs-security-review Related to feature or issues that needs security review label Dec 31, 2024

github-actions bot mentioned this pull request Jan 1, 2025

Monthly PR metrics report #32703

Closed

GavinZZ previously approved these changes Feb 20, 2025

View reviewed changes

GavinZZ self-assigned this Feb 20, 2025

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 20, 2025

Merge branch 'main' into stepfunction-createtrainingjob-addtag-permis…

2543f84

…sion

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 21, 2025

GavinZZ previously approved these changes Feb 21, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Feb 21, 2025

Merge branch 'main' into stepfunction-createtrainingjob-addtag-permis…

0e51269

…sion

GavinZZ approved these changes Feb 21, 2025

View reviewed changes

mergify bot merged commit 3b07346 into aws:main Feb 21, 2025
22 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2025

phuhung273 deleted the stepfunction-createtrainingjob-addtag-permission branch February 22, 2025 00:21

Conversation

phuhung273 commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

GavinZZ left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Feb 20, 2025

Uh oh!

mergify bot commented Feb 20, 2025

Uh oh!

mergify bot commented Feb 20, 2025

Uh oh!

phuhung273 commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

❌ Command disallowed due to command restrictions in the Mergify configuration.

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

GavinZZ commented Feb 21, 2025

Uh oh!

mergify bot commented Feb 21, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

aws-cdk-automation commented Feb 21, 2025

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Feb 21, 2025

Uh oh!

Uh oh!

github-actions bot commented Feb 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

phuhung273 commented Dec 16, 2024 •

edited

Loading

codecov bot commented Dec 16, 2024 •

edited

Loading