chore(cli-lib-alpha): remove dependency on in-source compilation#32500
Merged
mergify[bot] merged 1 commit intomainfrom Dec 12, 2024
Merged
chore(cli-lib-alpha): remove dependency on in-source compilation#32500mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
An integration test of `cli-lib-alpha` expects a test compilation `app.ts` -> `app.js` to have happened. In new projen-based repos, this isn't going to work, since we don't compile the test directories at all and run them through `ts-node` instead. Configure the test to use `ts-node` as well.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32500 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
=======================================
Hits 5629 5629
Misses 1347 1347
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mrgrain
approved these changes
Dec 12, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An integration test of
cli-lib-alphaexpects a test compilationapp.ts->app.jsto have happened.In new projen-based repos, this isn't going to work, since we don't compile the test directories at all and run them through
ts-nodeinstead. Configure the test to usets-nodeas well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license