Skip to content

chore: fix v2.172.0 changelog#32480

Merged
mergify[bot] merged 5 commits intomainfrom
sumughan/fix-2.172.0-changelog
Dec 24, 2024
Merged

chore: fix v2.172.0 changelog#32480
mergify[bot] merged 5 commits intomainfrom
sumughan/fix-2.172.0-changelog

Conversation

@sumupitchayan
Copy link
Copy Markdown
Contributor

@sumupitchayan sumupitchayan commented Dec 11, 2024 •
edited
Loading

Fixes mistakes in changelog

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@sumupitchayan
chore: fix v2.172.0 changelog
16287ee 
Signed-off-by: Sumu <sumughan@amazon.com>
@github-actions github-actions bot added the p2 label Dec 11, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team December 11, 2024 16:23
@sumupitchayan sumupitchayan marked this pull request as ready for review December 11, 2024 16:23
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 11, 2024
kaizencc
kaizencc approved these changes Dec 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, if you haven't yet, the release notes will need to be updated separately

@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Dec 11, 2024
@sumupitchayan
add extraline back
e4cc704 
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan removed the pr/do-not-merge This PR should not be merged at this time. label Dec 11, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.54%. Comparing base (ecfce7c) to head (7ba3772).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32480   +/-   ##
=======================================
  Coverage   80.54%   80.54%           
=======================================
  Files         106      106           
  Lines        6954     6954           
  Branches     1287     1287           
=======================================
  Hits         5601     5601           
  Misses       1175     1175           
  Partials      178      178
Flag Coverage Δ
suite.unit 80.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 80.54% <ø> (ø)

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 11, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 24, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7ba3772
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit fcf37ee into main Dec 24, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the sumughan/fix-2.172.0-changelog branch December 24, 2024 01:25
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 24, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sumupitchayan @aws-cdk-automation @kaizencc @moelasmar