chore: remove dependency on in-source compilation of bin/ directory#32476
chore: remove dependency on in-source compilation of bin/ directory#32476mergify[bot] merged 3 commits intomainfrom
bin/ directory#32476Conversation
The `bin/cdk` binary relies on the fact that `bin/cdk.ts` undergoes an in-source compilation, producing `bin/cdk.js` which is then required. This fails in a different setup where we only compile the `lib/` directory and nothing else. So skip one level of indirection: just put the code that loads the actual CLI entry point directly in the bash wrapper.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32476 +/- ##
=======================================
Coverage 78.60% 78.60%
=======================================
Files 107 107
Lines 7161 7161
Branches 1320 1320
=======================================
Hits 5629 5629
Misses 1347 1347
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The
bin/cdkbinary relies on the fact thatbin/cdk.tsundergoes an in-source compilation, producingbin/cdk.jswhich is then required.This fails in a different setup where we only compile the
lib/directory and nothing else.So skip one level of indirection: just put the code that loads the actual CLI entry point directly in the bash wrapper.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license