fix(cli): assuming a role from the INI file fails in non-commercial regions#32456
fix(cli): assuming a role from the INI file fails in non-commercial regions#32456otaviomacedo merged 2 commits intomainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32456 +/- ##
==========================================
- Coverage 78.67% 78.66% -0.02%
==========================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
==========================================
- Hits 5694 5693 -1
- Misses 1357 1358 +1
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technically speaking it always ignores it, which only becomes a visible problem in a non-commercial region 😛 |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
| requestHandler: AwsCliCompatible.requestHandlerBuilder(options.httpOptions), | ||
| customUserAgent: 'aws-cdk', | ||
| logger: options.logger, | ||
| region: await this.region(options.profile), |
There was a problem hiding this comment.
Is it possible to have unit test that ensures the region config is set so that the test will fail if one, in the future, accidentally removed this line?
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks: You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
|
Comments on closed issues and PRs are hard for our team to see. |
SDK v3 is ignoring the
regionconfiguration if it's a non-commercial region, such ascn-*.This PR also removes a duplicate test suite.
Fixes #32357.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license