Skip to content

chore: enable log timestamps by default#32448

Merged
mergify[bot] merged 7 commits intomainfrom
bobertzh/logging-fix
Dec 18, 2024
Merged

chore: enable log timestamps by default#32448
mergify[bot] merged 7 commits intomainfrom
bobertzh/logging-fix

Conversation

@HBobertz
Copy link
Copy Markdown
Contributor

@HBobertz HBobertz commented Dec 9, 2024 •
edited
Loading

Reason for this change

timestamps were no longer being printed for debug and trace level logging messages, because as part of the logging changes, I incidentally removed the timestamps from the debug() and trace() functions.

Description of changes

Re-added timestamps for whenever those 2 methods are called

i.e.

debug: "message"
is now
"[09:58:24] message"

info: "message"
is still
"message"

which was the previous functionality

Description of how you validated changes

Modified relevant unit tests and also did manual testing by verifying outputs of cdk commands on different cdk versions

# running cdk synth from local build of bobertzh/logging-fix
[15:08:06] CDK toolkit version: 0.0.0 (build 68b77e7)
[15:08:06] Command line arguments: {
... 
Resources:
  CDKMetadata:
...

# running cdk synth from live
CDK toolkit version: 2.173.0 (build b5c2189)
Command line arguments: {
...
Resources:
  CDKMetadata:
...

# running cdk synth from be000a251b781b0b0870930992793df5a2fc4b01 (parent commit)

[15:20:33] CDK toolkit version: 0.0.0 (build be000a2)
[15:20:33] Command line arguments: {
...
Resources:
  CDKMetadata:
...

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 9, 2024 15:09
@github-actions github-actions bot added the p2 label Dec 9, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 9, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Dec 9, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@HBobertz HBobertz marked this pull request as ready for review December 9, 2024 15:11
@HBobertz HBobertz requested a review from a team as a code owner December 9, 2024 15:11
@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 9, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (043f9db) to head (9a1af2c).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32448   +/-   ##
=======================================
  Coverage   78.86%   78.86%           
=======================================
  Files         108      108           
  Lines        7165     7165           
  Branches     1319     1319           
=======================================
  Hits         5651     5651           
  Misses       1330     1330           
  Partials      184      184
Flag Coverage Δ
suite.unit 78.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.86% <100.00%> (ø)

@mrgrain mrgrain added the pr/do-not-merge This PR should not be merged at this time. label Dec 9, 2024
mrgrain
mrgrain requested changes Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide an example of the previous correct output and what the current failure is. The PR description doesn't explain why this change is made.

@HBobertz
Copy link
Copy Markdown
Contributor Author

HBobertz commented Dec 11, 2024

Please provide an example of the previous correct output and what the current failure is. The PR description doesn't explain why this change is made.

Yup will do, also noticed a bug however that this pr is printing out this log message in this format

[12:26:49] No stacks match the name(s) [12:25:56] stack-name

so I'm gonna fix that, and then update the ticket with that information

@HBobertz HBobertz force-pushed the bobertzh/logging-fix branch from 4c205d8 to db3cb3e Compare December 12, 2024 19:42
@HBobertz HBobertz requested a review from mrgrain December 12, 2024 20:23
@mrgrain mrgrain removed the pr/do-not-merge This PR should not be merged at this time. label Dec 16, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 17, 2024

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Dec 18, 2024

@HBobertz are you getting this merged?

@HBobertz HBobertz added the pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested label Dec 18, 2024
@HBobertz
Copy link
Copy Markdown
Contributor Author

HBobertz commented Dec 18, 2024

@HBobertz are you getting this merged?

Yes just been swamped. It passed integ tests so it'll get auto-merged now

@aws-cdk-automation aws-cdk-automation dismissed their stale review December 18, 2024 16:18

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-cli-test-run This PR needs CLI tests run against it. label Dec 18, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 18, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9a1af2c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 18, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2d1e718 into main Dec 18, 2024
@mergify mergify bot deleted the bobertzh/logging-fix branch December 18, 2024 16:51
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HBobertz @aws-cdk-automation @mrgrain @otaviomacedo