feat(eks): add L2 constructs to support EKS Hybrid Nodes#32389
feat(eks): add L2 constructs to support EKS Hybrid Nodes#32389mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32389 +/- ##
=======================================
Coverage 80.92% 80.92%
=======================================
Files 236 236
Lines 14255 14255
Branches 2491 2491
=======================================
Hits 11536 11536
Misses 2434 2434
Partials 285 285
Flags with carried forward coverage won't be shown. Click here to find out more.
|
57f536c to
b24b684
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
9925674 to
1a96b54
Compare
|
@khushail Can you review this PR? The large diff is due to the several integration test snapshots being updated, I would suggest filtering |
99aac37 to
79b1d7e
Compare
b685715 to
b250b8c
Compare
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
8ecaece to
c02628a
Compare
|
@khushail all the GitHub actions passed except the CodeQL scanning results. It's complaining on integration test snapshot code that's autogenerated. Do you have any pointers on how to resolve this? |
|
@abhay-krishna , integration test snapshots need to be generated and submitted by you. Here is a guide on how to do that -https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md#running-integration-tests. You might want to look for existing closed PRs for additional help on generating these snapshot tests. Hope that would be helpful. |
@khushail Yes I understood that part, and I have submitted those integration test changes and snapshots too. However the CodeQL scanner is failing a check on one of those snapshots. Since these snapshots are generated code and I'm not handwriting them, I am not sure how to go about fixing them. |
c25a6ea to
04f834f
Compare
04f834f to
6d52147
Compare
dafb7aa to
3a9268c
Compare
Pull request has been modified.
61ead02 to
3491be8
Compare
GavinZZ
left a comment
There was a problem hiding this comment.
One minor comment and I'm happy to approve. Thank you!
3491be8 to
281f280
Compare
Pull request has been modified.
281f280 to
54d1c69
Compare
54d1c69 to
d112386
Compare
Pull request has been modified.
d112386 to
c291fd9
Compare
c291fd9 to
4c4d29f
Compare
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, thank you for addressing all the comments!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32362.
Reason for this change
This change allows users to specify the networking primitives for an EKS Hybrid nodes cluster through L2 constructs.
Description of changes
This PR introduces two new top-level fields called
remoteNodeNetworksandremotePodNetworksin the Cluster construct. Together, these allow users to specify the exact CIDRs ranges they want to use for their on-premises nodes and (optionally) pods. The Hybrid nodes feature requires that none of the node and pod CIDRs overlap with each other so I have also added validations for that.Description of how you validated changes
Added unit tests with different testcases involving different remote network configurations.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license