Skip to content

docs(elasticloadbalancingv2): removed statement reg unhealthyThresholdCount#32387

Merged
mergify[bot] merged 3 commits intomainfrom
khushail/nlbHealthcheck
Dec 9, 2024
Merged

docs(elasticloadbalancingv2): removed statement reg unhealthyThresholdCount#32387
mergify[bot] merged 3 commits intomainfrom
khushail/nlbHealthcheck

Conversation

@khushail
Copy link
Copy Markdown
Contributor

@khushail khushail commented Dec 5, 2024 •
edited
Loading

Issue # (if applicable)

Closes #32365 .

Reason for this change

There is no mention of unHealthyThresholdCount being the same with healthyThresholdCount in case of NLB in ELBV2 as stated in given docs -

Description of changes

removed the in-line comment

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team December 5, 2024 02:00
@github-actions github-actions bot added the p2 label Dec 5, 2024
@khushail khushail changed the title fix: removed statement reg unhealthyThresholdCount docs(elasticloadbalancingv2): removed statement reg unhealthyThresholdCount Dec 5, 2024
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Dec 5, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.67%. Comparing base (093c540) to head (592ce03).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32387   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         107      107           
  Lines        7237     7237           
  Branches     1329     1329           
=======================================
  Hits         5694     5694           
  Misses       1357     1357           
  Partials      186      186
Flag Coverage Δ
suite.unit 78.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.67% <ø> (ø)

@khushail khushail marked this pull request as ready for review December 6, 2024 21:32
GavinZZ
GavinZZ previously approved these changes Dec 6, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review December 9, 2024 15:41

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 9, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 592ce03
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 9, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 453045b into main Dec 9, 2024
@mergify mergify bot deleted the khushail/nlbHealthcheck branch December 9, 2024 16:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

+1 more reviewer

@GavinZZ GavinZZ GavinZZ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws_elasticloadbalancingv2: Incorrect statement that NLB health check healthy/unhealthy counts need to be the same

4 participants

@khushail @aws-cdk-automation @GavinZZ @kaizencc