Skip to content

feat(cognito): support for ALLOW_USER_AUTH explicit auth flow#32273

Merged
GavinZZ merged 4 commits intoaws:mainfrom
danielholmes:feat/cognito-user-auth-flow
Dec 4, 2024
Merged

feat(cognito): support for ALLOW_USER_AUTH explicit auth flow#32273
GavinZZ merged 4 commits intoaws:mainfrom
danielholmes:feat/cognito-user-auth-flow

Conversation

@danielholmes
Copy link
Copy Markdown
Contributor

@danielholmes danielholmes commented Nov 25, 2024

Reason for this change

Cognito released some new auth flow features which have made their way into cloudformation. I want to be able to use the new USER_AUTH sign in on a UserPoolClient.

Description of changes

I've added a user option to the AuthFlow struct for UserPoolClient. This naming matches the naming convention for the other settings in AuthFlow so while user is a very generic label, I think it makes sense in the context of this AuthFlow struct. i.e. the current properties are:

adminUserPassword -> ADMIN_USER_PASSWORD_AUTH
custom -> CUSTOM_AUTH
userPassword -> USER_PASSWORD_AUTH
userSrp -> USER_SRP_AUTH

This property then sets the "ALLOW_USER_AUTH" value in the ExplicitAuthFlows of the UserPoolClient.

Description of how you validated changes

I added the setting to both the unit and integration tests which have all auth types enabled.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Nov 25, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 25, 2024 16:00
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 25, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@danielholmes danielholmes changed the title feat(aws-cognito): support for ALLOW_USER_AUTH explicit auth flow feat(cognito): support for ALLOW_USER_AUTH explicit auth flow Nov 25, 2024
@danielholmes danielholmes force-pushed the feat/cognito-user-auth-flow branch from ba50329 to 46787e4 Compare November 25, 2024 17:21
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 25, 2024 17:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 25, 2024
@danielholmes danielholmes force-pushed the feat/cognito-user-auth-flow branch from 46787e4 to 0c5f94f Compare November 25, 2024 17:57
GavinZZ
GavinZZ previously approved these changes Nov 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 29, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (bf77e51) to head (e5b1d18).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #32273      +/-   ##
==========================================
- Coverage   78.50%   78.48%   -0.02%     
==========================================
  Files         106      106              
  Lines        7201     7201              
  Branches     1321     1321              
==========================================
- Hits         5653     5652       -1     
- Misses       1361     1362       +1     
  Partials      187      187
Flag Coverage Δ
suite.unit 78.48% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 78.48% <ø> (-0.02%) ⬇️

@github-actions github-actions bot mentioned this pull request Dec 1, 2024
Closed
@mergify mergify bot dismissed GavinZZ’s stale review December 2, 2024 18:29

Pull request has been modified.

GavinZZ
GavinZZ previously approved these changes Dec 2, 2024
View reviewed changes
@mergify mergify bot dismissed GavinZZ’s stale review December 2, 2024 22:19

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Dec 3, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e5b1d18
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Dec 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Tietew Tietew mentioned this pull request Dec 3, 2024
Merged
1 task
@GavinZZ GavinZZ merged commit c5bcfdc into aws:main Dec 4, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@mazyu36 mazyu36 mazyu36 approved these changes

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danielholmes @aws-cdk-automation @mazyu36 @GavinZZ