Skip to content

feat(lambda): support for Provisioned Pollers#32205

Merged
mergify[bot] merged 9 commits intoaws:mainfrom
roger-zhangg:pollers
Nov 21, 2024
Merged

feat(lambda): support for Provisioned Pollers#32205
mergify[bot] merged 9 commits intoaws:mainfrom
roger-zhangg:pollers

Conversation

@roger-zhangg
Copy link
Copy Markdown
Member

@roger-zhangg roger-zhangg commented Nov 20, 2024

Reason for this change

Lambda is introducing a new property in Event Sources named ProvisionedPollerConfig to set provisioned pollers that read from the event sources. When specified, it allows control over the minimum and maximum number of pollers that can be provisioned to process events from the source.

This feature is currently supported for MSK and Self-managed Kafka event sources.

Description of changes

This new property can be opted in by setting the ProvisionedPollerConfig field while creating event sources. The example of setting ProvisionedPollerConfig for is shown below:

fn.addEventSource(new sources.ManagedKafkaEventSource(
  {
    clusterArn,
    topic: kafkaTopic,
    startingPosition: lambda.StartingPosition.TRIM_HORIZON,
    provisionedPollerConfig: {
      minimumPollers: 1,
      maximumPollers: 3,
    },
  }))

Description of how you validated changes

Have added unit test and integration test to validate the implementation

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK labels Nov 20, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 20, 2024 00:42
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.17%. Comparing base (326e2c6) to head (2d36ff4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32205   +/-   ##
=======================================
  Coverage   77.17%   77.17%           
=======================================
  Files         105      105           
  Lines        7169     7169           
  Branches     1315     1315           
=======================================
  Hits         5533     5533           
  Misses       1455     1455           
  Partials      181      181
Flag Coverage Δ
suite.unit 77.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.17% <ø> (ø)
---- 🚨 Try these New Features:

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2024
@xazhao xazhao added the pr/do-not-merge This PR should not be merged at this time. label Nov 20, 2024
xazhao
xazhao previously approved these changes Nov 20, 2024
View reviewed changes
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2024
@mergify mergify bot dismissed xazhao’s stale review November 20, 2024 07:28

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2024
GavinZZ
GavinZZ previously requested changes Nov 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit comments

GavinZZ
GavinZZ previously approved these changes Nov 20, 2024
View reviewed changes
@mergify mergify bot dismissed GavinZZ’s stale review November 20, 2024 22:54

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 20, 2024
@GavinZZ
Copy link
Copy Markdown
Member

GavinZZ commented Nov 21, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 21, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

@mergify mergify bot dismissed GavinZZ’s stale review November 21, 2024 21:08

Pull request has been modified.

GavinZZ
GavinZZ previously approved these changes Nov 21, 2024
View reviewed changes
@xazhao xazhao removed the pr/do-not-merge This PR should not be merged at this time. label Nov 21, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review November 21, 2024 23:03

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 21, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 2d36ff4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 21, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 68b969e into aws:main Nov 21, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 21, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@xazhao xazhao xazhao approved these changes

@GavinZZ GavinZZ GavinZZ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@roger-zhangg @GavinZZ @aws-cdk-automation @xazhao @Vandita2020 @moelasmar