feat(lambda): support observability for ESM ( DDB, Kinesis, SQS)#32204
Merged
mergify[bot] merged 9 commits intoaws:mainfrom Nov 20, 2024
Merged
feat(lambda): support observability for ESM ( DDB, Kinesis, SQS)#32204mergify[bot] merged 9 commits intoaws:mainfrom
mergify[bot] merged 9 commits intoaws:mainfrom
Conversation
xazhao
reviewed
Nov 20, 2024
Contributor
|
also the build failed with following error |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32204 +/- ##
=======================================
Coverage 77.18% 77.18%
=======================================
Files 105 105
Lines 7161 7161
Branches 1312 1312
=======================================
Hits 5527 5527
Misses 1454 1454
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xazhao
approved these changes
Nov 20, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
Lambda is introducing a new property in Event Sources named
MetricsConfigto get enhanced metrics for user's event source that captures each stage of processing. Through this metrics customer can track flow of events through their EDA pipelines.This feature is currently supported for
DynamoDB,KinesisandSQSevent sources only.Description of changes
This new property can be opted in by setting the
MetricsConfigfield while creating event sources. The example of opting forMetricsConfigfor dynamoDB event is shown below:Today there is only 1 metric type: EventCount. The
metricsarray can be either one element withEventCountor an empty array. More configuration support will be available in futureDescription of how you validated changes
Have added unit test and integration test to validate the implementation
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license