feat(elasticloadbalancingv2): ip address type for both network and application target group#32189
Conversation
| * Must be 5 to 300 seconds | ||
| * | ||
| * @default 10 seconds if protocol is `GENEVE`, 35 seconds if target type is `lambda`, else 30 seconds | ||
| * @default - 10 seconds if protocol is `GENEVE`, 35 seconds if target type is `lambda`, else 30 seconds |
There was a problem hiding this comment.
I have corrected the usage of hyphens in some @default descriptions. If it is preferable, I can separate this into a different PR.
| /** | ||
| * The type of IP addresses of the targets registered with the target group. | ||
| * | ||
| * @default undefined - ELB defaults to IPv4 |
There was a problem hiding this comment.
I think @default IPv4 is sufficient, but I have written it this way because several maintainers have recently recommended this approach.
There was a problem hiding this comment.
Thanks! I like it this way so that we know both the CDK default behaviour and CFN default behaviour.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32189 +/- ##
=======================================
Coverage 77.46% 77.46%
=======================================
Files 105 105
Lines 7168 7168
Branches 1314 1314
=======================================
Hits 5553 5553
Misses 1433 1433
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GavinZZ
left a comment
There was a problem hiding this comment.
LGTM, thanks for your consistent and high-quality contribution.
| /** | ||
| * The type of IP addresses of the targets registered with the target group. | ||
| * | ||
| * @default undefined - ELB defaults to IPv4 |
There was a problem hiding this comment.
Thanks! I like it this way so that we know both the CDK default behaviour and CFN default behaviour.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
|
@mergify update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
Both Application and Network target group supports for specifying IP address type.
Application: https://docs.aws.amazon.com/elasticloadbalancing/latest/application/load-balancer-target-groups.html#target-group-ip-address-type
Network: https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-group-ip-address-type
Description of changes
TargetGroupIpAddressTypeenumIpAddressTypeinaws-elassticloadbalancingv2module, I don't nameIpAddressTypeipAddressTypeprop toBaseTargetGroupPropsDescription of how you validated changes
Add both unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license