Skip to content

chore(contributing): mention manual PR merge option #32126

Merged
mergify[bot] merged 2 commits intomainfrom
epolon/manual-pr-merge
Nov 14, 2024
Merged

chore(contributing): mention manual PR merge option #32126
mergify[bot] merged 2 commits intomainfrom
epolon/manual-pr-merge

Conversation

@iliapolo
Copy link
Copy Markdown
Contributor

@iliapolo iliapolo commented Nov 14, 2024

Folks are probably already doing this, but just clarify that when a PR is failing status checks you can ping a maintainer for a manual merge if you think its justified.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 14, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2024 09:39
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 14, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.14%. Comparing base (fb97684) to head (61c12a1).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32126   +/-   ##
=======================================
  Coverage   77.14%   77.14%           
=======================================
  Files         105      105           
  Lines        7163     7163           
  Branches     1311     1311           
=======================================
  Hits         5526     5526           
  Misses       1457     1457           
  Partials      180      180
Flag Coverage Δ
suite.unit 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.14% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 14, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 14, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 61c12a1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 339fed1 into main Nov 14, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 14, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the epolon/manual-pr-merge branch November 14, 2024 14:31
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 14, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iliapolo @aws-cdk-automation @rix0rrr