Skip to content

chore(opensearch): support OpenSearch version 2.17#32121

Merged
mergify[bot] merged 5 commits intoaws:mainfrom
mazyu36:opensearch-version-2-1-7
Nov 17, 2024
Merged

chore(opensearch): support OpenSearch version 2.17#32121
mergify[bot] merged 5 commits intoaws:mainfrom
mazyu36:opensearch-version-2-1-7

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Nov 14, 2024

Issue # (if applicable)

N/A

Reason for this change

Support OpenSearch version 2.17.
https://docs.aws.amazon.com/opensearch-service/latest/developerguide/release-notes.html

Description of changes

Add Enum.

Description of how you validated changes

Add unit tests and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 14, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 14, 2024 02:13
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 14, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Nov 14, 2024

Exemption Request: As this only involves adding an enum for versions, I think that modifying the README was unnecessary.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Nov 14, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.18%. Comparing base (f75dc72) to head (5a67f4f).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #32121   +/-   ##
=======================================
  Coverage   77.18%   77.18%           
=======================================
  Files         105      105           
  Lines        7163     7163           
  Branches     1311     1311           
=======================================
  Hits         5529     5529           
  Misses       1454     1454           
  Partials      180      180
Flag Coverage Δ
suite.unit 77.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 77.18% <ø> (ø)

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 14, 2024
GavinZZ
GavinZZ approved these changes Nov 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'd treat it more as a chore as it's version support. Updating the title.

@GavinZZ GavinZZ changed the title feat(opensearch): support OpenSearch version 2.17 chore(opensearch): support OpenSearch version 2.17 Nov 15, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review November 15, 2024 20:21

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 15, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 15, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Nov 15, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 15, 2024

update

☑️ Nothing to do

Details
  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Nov 15, 2024

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 15, 2024

refresh

✅ Pull request refreshed

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Nov 16, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 16, 2024

update

☑️ Nothing to do

Details
  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Nov 16, 2024

@Mergifyio refresh

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 16, 2024

refresh

✅ Pull request refreshed

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Nov 16, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 16, 2024

update

☑️ Nothing to do

Details
  • queue-position = -1 [📌 update requirement]
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@mrgrain
Copy link
Copy Markdown
Contributor

mrgrain commented Nov 17, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 17, 2024

update

☑️ Nothing to do

Details
  • #commits-behind > 0 [📌 update requirement]
  • queue-position = -1 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 17, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5a67f4f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 50d11a3 into aws:main Nov 17, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 17, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024
@mazyu36 mazyu36 deleted the opensearch-version-2-1-7 branch November 17, 2024 23:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+2 more reviewers

@GavinZZ GavinZZ GavinZZ approved these changes

@badmintoncryer badmintoncryer badmintoncryer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mazyu36 @mrgrain @aws-cdk-automation @GavinZZ @badmintoncryer @iliapolo