fix(cdk): use built-in source map support#32115
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
5c2d3ad to
b24306d
Compare
b24306d to
a0d49f9
Compare
0fdf526 to
333104b
Compare
333104b to
fd88b1e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32115 +/- ##
==========================================
+ Coverage 77.15% 77.17% +0.01%
==========================================
Files 105 105
Lines 7165 7162 -3
Branches 1312 1311 -1
==========================================
- Hits 5528 5527 -1
+ Misses 1457 1455 -2
Partials 180 180
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c15b09b to
8b0df3d
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@Mergifyio requeue |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
We don't need to use the third party
source-map-supportpackage anymore to achieve the same result.Description of changes
We use
process.setSourceMapsEnabled(true)instead. However unlike the previous package, this command needs to be run before we import any other files, otherwise it won't work. We therefore move it into the executable.Description of how you validated changes
Manual verification
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license