chore: change logging to use a single base logging method#32081
chore: change logging to use a single base logging method#32081mergify[bot] merged 20 commits intomainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #32081 +/- ##
==========================================
+ Coverage 77.46% 78.19% +0.72%
==========================================
Files 105 105
Lines 7168 7176 +8
Branches 1314 1318 +4
==========================================
+ Hits 5553 5611 +58
+ Misses 1433 1377 -56
- Partials 182 188 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
packages/aws-cdk/lib/cli.ts
Outdated
|
|
||
| if (argv.verbose) { | ||
| setLogLevel(argv.verbose); | ||
| setLogLevelByValue(argv.verbose+2); |
There was a problem hiding this comment.
That's unexepected. If intentional it needs a comment why.
| // with the output calculations. | ||
| this.oldLogLevel = logLevel; | ||
| setLogLevel(LogLevel.DEFAULT); | ||
| setLogLevel(LogLevel.INFO); |
There was a problem hiding this comment.
okay for now but we will need to get rid of this eventually. setLogLevel should only every be set once as it affects the output. These messages just need to be logged with the correct level (or not at all).
mrgrain
left a comment
There was a problem hiding this comment.
1 small request. Otherwise the build is not passing.
| // if one -v, log at a DEBUG level | ||
| // if 2 -v, log at a TRACE level |
There was a problem hiding this comment.
What about -vvv
| // if one -v, log at a DEBUG level | |
| // if 2 -v, log at a TRACE level | |
| // if -v, log at a DEBUG level | |
| // if -vv, log at a TRACE level |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Closes #32039
Modified the existing logging mechanism to route to a single log function. Adapted the existing structure so that very minimal changes were required for existing logging functions and how they are used today
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license