Skip to content

chore(kinesisfirehose-alpha): update README to clarify default destination encryption setting#32016

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
paulhcsun:firehose-s3-encryption-readme
Nov 5, 2024
Merged

chore(kinesisfirehose-alpha): update README to clarify default destination encryption setting#32016
mergify[bot] merged 2 commits intoaws:mainfrom
paulhcsun:firehose-s3-encryption-readme

Conversation

@paulhcsun
Copy link
Copy Markdown
Contributor

Description of changes

Clarify in the README that the default encryption for the destination is disabled but that it uses the default encryption setting of the destination S3 bucket.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 4, 2024 23:46
@github-actions github-actions bot added the p2 label Nov 4, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 4, 2024
@paulhcsun
Copy link
Copy Markdown
Contributor Author

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 4, 2024

update

☑️ Nothing to do

Details
  • #commits-behind > 0 [📌 update requirement]
  • -closed [📌 update requirement]
  • -conflict [📌 update requirement]
  • queue-position = -1 [📌 update requirement]

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: a908d3a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1466f93 into aws:main Nov 5, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
@paulhcsun paulhcsun deleted the firehose-s3-encryption-readme branch November 5, 2024 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants