Skip to content

chore(s3): add more details to prune and destinationKeyPrefix property#32011

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
xazhao:s3-bucket-doc
Nov 5, 2024
Merged

chore(s3): add more details to prune and destinationKeyPrefix property#32011
mergify[bot] merged 2 commits intoaws:mainfrom
xazhao:s3-bucket-doc

Conversation

@xazhao
Copy link
Copy Markdown
Contributor

@xazhao xazhao commented Nov 4, 2024

Reason for this change

prune and destinationKeyPrefix properties documentation is not super clear for users. Adding more details to behaviors when setting/unsetting the property.

Description of changes

Description of how you validated changes

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 4, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 4, 2024 19:52
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Nov 4, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 4, 2024
Copy link
Copy Markdown

@caller79 caller79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a significant improvement in the quality of the documentation here.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 5, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@xazhao
Copy link
Copy Markdown
Contributor Author

xazhao commented Nov 5, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 18cdabe
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit ae29bb5 into aws:main Nov 5, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 5, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants