Skip to content

chore(docs): fix invalid anchor links in DESIGN_GUIDELINES#31997

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
ren-yamanashi:doc-update-design-guidelines
Nov 6, 2024
Merged

chore(docs): fix invalid anchor links in DESIGN_GUIDELINES#31997
mergify[bot] merged 3 commits intoaws:mainfrom
ren-yamanashi:doc-update-design-guidelines

Conversation

@ren-yamanashi
Copy link
Copy Markdown
Contributor

@ren-yamanashi ren-yamanashi commented Nov 3, 2024

Issue # (if applicable)

n/A

Description of changes

Fix invalid anchor links in DESIGN_GUIDELINES.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 3, 2024 09:25
@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 labels Nov 3, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 3, 2024
badmintoncryer
badmintoncryer approved these changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Closed
kaizencc
kaizencc previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the eagle eyes!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 4, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@ren-yamanashi
Copy link
Copy Markdown
Contributor Author

ren-yamanashi commented Nov 5, 2024 •
edited
Loading

@kaizencc

Thank you for the approve! It seems that the CI has failed, so should I manually updating this branch?

@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Nov 5, 2024

@ren-yamanashi Please comment @mergifyio update. When it's not working well, it fails again, but if you keep trying without giving up, it occasionally succeeds😁

@ren-yamanashi
Copy link
Copy Markdown
Contributor Author

ren-yamanashi commented Nov 5, 2024

@badmintoncryer

Thank you for your comment! I'll try it right away!

@ren-yamanashi
Copy link
Copy Markdown
Contributor Author

ren-yamanashi commented Nov 5, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@ren-yamanashi
Copy link
Copy Markdown
Contributor Author

ren-yamanashi commented Nov 5, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Nov 5, 2024

@ren-yamanashi I apologize for the lack of information, but it’s better to run it with some time in between!

@ren-yamanashi
Copy link
Copy Markdown
Contributor Author

ren-yamanashi commented Nov 5, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@ren-yamanashi
Copy link
Copy Markdown
Contributor Author

ren-yamanashi commented Nov 5, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@ren-yamanashi
Copy link
Copy Markdown
Contributor Author

ren-yamanashi commented Nov 5, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 5, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/request-cli-integ-test.yml without workflows permission

@moelasmar moelasmar changed the title docs: fix invalid anchor links in DESIGN_GUIDELINES chore(docs): fix invalid anchor links in DESIGN_GUIDELINES Nov 6, 2024
moelasmar
moelasmar previously approved these changes Nov 6, 2024
View reviewed changes
@mergify mergify bot dismissed stale reviews from kaizencc and moelasmar November 6, 2024 08:18

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 6, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 6, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d39da61
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4af1564 into aws:main Nov 6, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 6, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2024
@ren-yamanashi ren-yamanashi deleted the doc-update-design-guidelines branch November 10, 2025 02:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc left review comments

+2 more reviewers

@badmintoncryer badmintoncryer badmintoncryer approved these changes

@moelasmar moelasmar moelasmar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ren-yamanashi @badmintoncryer @aws-cdk-automation @kaizencc @moelasmar