Skip to content

chore(glue): fix broken link#31994

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
badmintoncryer:fixGlueDocs
Nov 4, 2024
Merged

chore(glue): fix broken link#31994
mergify[bot] merged 2 commits intoaws:mainfrom
badmintoncryer:fixGlueDocs

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Nov 2, 2024 •
edited
Loading

Issue # (if applicable)

None

Reason for this change

The generated document is broken due to an incorrect format.

@see https://example.com Some redundant phrases
スクリーンショット 2024-11-02 20 00 25

Description of changes

Remove redundant description.

Description of how you validated changes

None

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Nov 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 2, 2024 12:47
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Nov 2, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 2, 2024
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Closed
kaizencc
kaizencc approved these changes Nov 4, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonus points if you add a linter rule for any spaces that are found on the same line as the @see doc tag :). That might need to be handled by jsii anyway.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 4, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Nov 4, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: aeeeb34
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 6190c14 into aws:main Nov 4, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 4, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 4, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2024
@badmintoncryer badmintoncryer deleted the fixGlueDocs branch November 4, 2024 22:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kaizencc kaizencc kaizencc approved these changes

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@badmintoncryer @aws-cdk-automation @kaizencc