chore(codepipeline): generate stack name in codepipeline when stack name is unresolved token#31967
chore(codepipeline): generate stack name in codepipeline when stack name is unresolved token#31967mergify[bot] merged 13 commits intomainfrom
Conversation
|
Pending integration test. |
8f6a230 to
ff74b5e
Compare
Leo10Gama
left a comment
There was a problem hiding this comment.
Looks pretty good, just a few minor comments. The description also mentions unit tests added but I only see an integ test change. If we can only see the changes in effect when deploying, it should be fine to omit unit tests, but we should update the PR description.
packages/aws-cdk-lib/aws-codepipeline/lib/private/cross-region-support-stack.ts
Outdated
Show resolved
Hide resolved
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31436.
Reason for this change
When nested stack is used with CodePipeline, the stack name is actually a token which will fail regex check. We can't simply add a
Token.isUnresolvedcheck before the regex check because stack name must be a resolved string otherwise the template file would includeToken[xxx].Description of changes
The only feasible fix would be allowing users to override the nested stack name if users provide one. Currently nested stack names are auto-generated and are a token value. Allow users to specify the stack name.
Description of how you validated changes
New integ tests pass. Existing tests pass.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license