Skip to content

feat(rds): configure autoMinorVersionUpgrade for a database cluster#31962

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
badmintoncryer:autoMinorVersionUpgrade
Nov 1, 2024
Merged

feat(rds): configure autoMinorVersionUpgrade for a database cluster#31962
mergify[bot] merged 8 commits intoaws:mainfrom
badmintoncryer:autoMinorVersionUpgrade

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Oct 31, 2024

Issue # (if applicable)

None

Reason for this change

We can configure `autoMinorVersionUpgrade' for a database cluster, but AWS CDK cannot do this.

Description of changes

Add autoMinorVersionUpgrade to DatabaseClusterBaseProps.

Description of how you validated changes

Add both unit and integ tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 31, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 31, 2024 14:52
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Oct 31, 2024
@badmintoncryer badmintoncryer marked this pull request as ready for review October 31, 2024 14:54
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review October 31, 2024 15:06

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2024
});
```

By default, automatic minor version upgrades for the engine type are enabled in a cluster, but you can also disable this.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me here @badmintoncryer, thanks for the PR

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2024
@badmintoncryer
Copy link
Copy Markdown
Contributor Author

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 1, 2024

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 8f0ea03
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0fb6106 into aws:main Nov 1, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
@badmintoncryer badmintoncryer deleted the autoMinorVersionUpgrade branch November 1, 2024 02:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants