Skip to content

feat(bootstrap): add lifecycle rule to abort multipart uploads after 7 days#31956

Merged
mergify[bot] merged 7 commits intomainfrom
sumughan/fix-bootstrap-AbortIncompleteMultipartUpload
Oct 31, 2024
Merged

feat(bootstrap): add lifecycle rule to abort multipart uploads after 7 days#31956
mergify[bot] merged 7 commits intomainfrom
sumughan/fix-bootstrap-AbortIncompleteMultipartUpload

Conversation

@sumupitchayan
Copy link
Copy Markdown
Contributor

@sumupitchayan sumupitchayan commented Oct 31, 2024

Closes #29045

Reason for this change

AWS Trusted Advisor rolled out the S3 Incomplete Multipart Upload Abort Configuration check to help users manage costs associated with Amazon S3 storage

Description of changes

Added a new lifecycle rule to the bucket and incremented the bootstrap version to 24.

Description of how you validated changes

N/a

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: Sumu <sumughan@amazon.com>
@aws-cdk-automation aws-cdk-automation requested a review from a team October 31, 2024 03:04
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels Oct 31, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 31, 2024
Signed-off-by: Sumu <sumughan@amazon.com>
@sumupitchayan sumupitchayan changed the title chore(bootstrap): add lifecycle rule to abort multipart uploads after 7 days feat(bootstrap): add lifecycle rule to abort multipart uploads after 7 days Oct 31, 2024
@sumupitchayan sumupitchayan added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Oct 31, 2024
@sumupitchayan sumupitchayan marked this pull request as ready for review October 31, 2024 03:22
Signed-off-by: Sumu <sumughan@amazon.com>
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 31, 2024
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What Kaizen said was worth a "Request Changes" 😉

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 31, 2024
Signed-off-by: Sumu <sumughan@amazon.com>
Signed-off-by: Sumu <sumughan@amazon.com>
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 1881b17
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b800da8 into main Oct 31, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 31, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the sumughan/fix-bootstrap-AbortIncompleteMultipartUpload branch October 31, 2024 14:45
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Bootstrap stack): (Abort failed multipart upload after 7 days)

5 participants