Skip to content

feat(route53): support HTTPS, SSHFP, SVCB, and TLSA DNS resource record#31955

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
mazyu36:route53-add-record-type
Nov 1, 2024
Merged

feat(route53): support HTTPS, SSHFP, SVCB, and TLSA DNS resource record#31955
mergify[bot] merged 3 commits intoaws:mainfrom
mazyu36:route53-add-record-type

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Oct 31, 2024

Issue # (if applicable)

N/A

Reason for this change

Route53 supports additional record types.

Ref: https://aws.amazon.com/about-aws/whats-new/2024/10/amazon-route-53-https-sshfp-svcb-tlsa-dns-support/

These are already supported in CFn.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-route53-recordset.html#cfn-route53-recordset-type

Description of changes

Add Enum.

Description of how you validated changes

Nothing because only enum added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 31, 2024 00:42
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Oct 31, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 31, 2024
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 1, 2024
@sumupitchayan sumupitchayan changed the title chore(route53): support HTTPS, SSHFP, SVCB, and TLSA DNS resource record feat(route53): support HTTPS, SSHFP, SVCB, and TLSA DNS resource record Nov 1, 2024
Copy link
Copy Markdown
Contributor

@sumupitchayan sumupitchayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mazyu36 thanks for adding this, just a heads up though that PR's like this should be feat instead of chore - I'll add the labels for the PR linter exemptions

@sumupitchayan sumupitchayan added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Nov 1, 2024
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Nov 1, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 13f3541
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit afc2b0d into aws:main Nov 1, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 1, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 1, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2024
@mazyu36 mazyu36 deleted the route53-add-record-type branch November 2, 2024 00:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants