fix(sqs): queue with fifo: false does not deploy#31922
Conversation
The `FifoQueue` property in CloudFormation can only be `true`, or must be absent. Make it so that a `fifo: false` configuration doesn't output FifoQueue at all. Closes #8550.
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
left a comment
There was a problem hiding this comment.
a difficult fix, surely
fifo: false does not deployfifo: false does not deploy
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
The
FifoQueueproperty in CloudFormation can only betrue, or must be absent. If you passFifoQueue: false, you will receive the following error:Make it so that a
fifo: falseconfiguration doesn't output FifoQueue at all.Closes #8550.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license