Skip to content

chore: add Amplify integration tests#31921

Merged
mergify[bot] merged 3 commits intomainfrom
huijbers/amplify-integ
Oct 29, 2024
Merged

chore: add Amplify integration tests#31921
mergify[bot] merged 3 commits intomainfrom
huijbers/amplify-integ

Conversation

@rix0rrr
Copy link
Copy Markdown
Contributor

@rix0rrr rix0rrr commented Oct 28, 2024

Test integration with the Amplify client, that uses CDK under the hood.

Creates a new project, deploys it, and then deletes it again.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Test integration with the Amplify client, that uses CDK under the hood.

Creates a new project, deploys it, and then deletes it again.
@rix0rrr rix0rrr requested a review from a team October 28, 2024 16:46
@aws-cdk-automation aws-cdk-automation requested a review from a team October 28, 2024 16:46
@github-actions github-actions bot added the p2 label Oct 28, 2024

integTest('amplify integration', withTemporaryDirectory(withPackages(async (context) => {
const shell = ShellHelper.fromContext(context);
// await context.packages.makeCliAvailable();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// await context.packages.makeCliAvailable();

pj.devDependencies['aws-cdk'] = cliVersion;
pj.devDependencies['aws-cdk-lib'] = libVersion;
await fs.writeFile(filename, JSON.stringify(pj, undefined, 2), { encoding: 'utf-8' });
} No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
}
}

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 28, 2024
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe disable telemetry? https://docs.amplify.aws/react/reference/telemetry/

export AMPLIFY_DISABLE_TELEMETRY=1

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: d2ae910
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a279b98 into main Oct 29, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 29, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the huijbers/amplify-integ branch October 29, 2024 09:41
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants