chore(scheduler-alpha): make LambdaInvoke prop optional#31887
Merged
mergify[bot] merged 2 commits intoaws:mainfrom Oct 24, 2024
Merged
chore(scheduler-alpha): make LambdaInvoke prop optional#31887mergify[bot] merged 2 commits intoaws:mainfrom
mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
73f1634 to
fccd0c3
Compare
kaizencc
approved these changes
Oct 24, 2024
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
gracelu0
approved these changes
Oct 24, 2024
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Tracking #31785.
Reason for this change
Improve ergonomics of the
LambdaInvokeconstructor signature. The second argument is not required so we should not force customers to pass in an empty object.Description of changes
Make the
LambdaInvokepropargument default to empty object.Description of how you validated changes
Unit test updated to omit the
propargument if no props are being passed.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license