Skip to content

chore(ec2): add missing interface VPC endpoints#31882

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
badmintoncryer:addInterfaceEndpoint
Oct 24, 2024
Merged

chore(ec2): add missing interface VPC endpoints#31882
mergify[bot] merged 4 commits intoaws:mainfrom
badmintoncryer:addInterfaceEndpoint

Conversation

@badmintoncryer
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer commented Oct 24, 2024

Issue # (if applicable)

None

Reason for this change

There are some interface VPC endpoints which is not supported by AWS CDK.

Description of changes

Add three interface VPC endpoints

  • WorkMail (com.amazonaws.region.workmail)
  • AWS End User Messaging Social (com.amazonaws.region.social-messaging)
  • AWS Price List (com.amazonaws.region.pricing.api)

Description of how you validated changes

Execute AWS CLI:

❯ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep workmail
    "com.amazonaws.us-east-1.workmail",

❯ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep social
    "com.amazonaws.us-east-1.social-messaging",

❯ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep pricing
    "com.amazonaws.us-east-1.pricing.api",

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 24, 2024 13:36
@github-actions github-actions bot added distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 labels Oct 24, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 24, 2024
GavinZZ
GavinZZ previously approved these changes Oct 24, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 24, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@badmintoncryer
Copy link
Copy Markdown
Contributor Author

badmintoncryer commented Oct 24, 2024

@mergify update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 24, 2024

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/github-merit-badger.yml without workflows permission

@mergify mergify bot dismissed GavinZZ’s stale review October 24, 2024 23:14

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 24, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 251d2b5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 09256db into aws:main Oct 24, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 24, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2024
@badmintoncryer badmintoncryer deleted the addInterfaceEndpoint branch October 25, 2024 00:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@badmintoncryer @aws-cdk-automation @GavinZZ