Skip to content

chore(kinesisfirehose-alpha): update README with Logging resource clarification#31861

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
paulhcsun:firehose-readme-logging-clarification
Oct 23, 2024
Merged

chore(kinesisfirehose-alpha): update README with Logging resource clarification#31861
mergify[bot] merged 3 commits intoaws:mainfrom
paulhcsun:firehose-readme-logging-clarification

Conversation

@paulhcsun
Copy link
Copy Markdown
Contributor

Description of changes

Clarify in README that a LogGroup and LogStream with default settings will be created.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 23, 2024 02:27
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 23, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 23, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 23, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: af32dfa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2e691b6 into aws:main Oct 23, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 23, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants