fix(ec2): allow NAT instance to associate public IP#31812
Conversation
| /** | ||
| * Whether to associate a public IP address to the primary network interface attached to this instance. | ||
| * | ||
| * @default false |
There was a problem hiding this comment.
I believe here you are referring to the CFN default value, but not the CDK one. I think it is better to mention that default value is null.
moelasmar
left a comment
There was a problem hiding this comment.
LGTM, left minor comment
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #31711
Reason for this change
When we set mapPublicIpOnLaunch=false for public subnets, NAT instances does not get public IP addresses assigned, resulting in non-working NAT instances.
Disabling mapPublicIpOnLaunch is recommended as AWS Config rule (and cdk-nag as well.)
https://docs.aws.amazon.com/config/latest/developerguide/subnet-auto-assign-public-ip-disabled.html
Description of changes
Support
associatePublicIpAddressDescription of how you validated changes
New unit and integ tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license