Skip to content

feat(amplify-alpha): support custom response headers in monorepo structures#31771

Merged
mergify[bot] merged 20 commits intoaws:mainfrom
georeeve:amplify-monorepo-custom-headers
Jun 18, 2025
Merged

feat(amplify-alpha): support custom response headers in monorepo structures#31771
mergify[bot] merged 20 commits intoaws:mainfrom
georeeve:amplify-monorepo-custom-headers

Conversation

@georeeve
Copy link
Copy Markdown
Contributor

@georeeve georeeve commented Oct 15, 2024 •
edited
Loading

Issue # (if applicable)

Closes #31758.

Reason for this change

The current custom response headers implementation does not support Amplify apps with monorepo structures, this is due to a difference in the YAML formats for these apps: https://docs.aws.amazon.com/amplify/latest/userguide/custom-header-YAML-format.html

Description of changes

An appRoot property has been added to CustomResponseHeader, which specifies the appRoot from the build spec to use for the output YAML.

Description of how you validated changes

I added unit tests and tested the implementation using a sample deployment. I'm happy to add integration tests if required.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. p2 labels Oct 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 15, 2024 23:07
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@georeeve georeeve mentioned this pull request Oct 15, 2024
Closed
1 task
@aws-cdk-automation aws-cdk-automation added pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run and removed pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run labels Oct 16, 2024
@georeeve georeeve marked this pull request as ready for review October 16, 2024 08:08
@aws-cdk-automation aws-cdk-automation added pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. and removed pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 16, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 16, 2024 09:25

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 16, 2024
@github-actions github-actions bot added the effort/medium Medium work item – several days of effort label Oct 17, 2024
@github-actions github-actions bot mentioned this pull request Nov 1, 2024
Closed
@georeeve georeeve mentioned this pull request Jan 8, 2025
Open
1 task
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jan 30, 2025

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Feb 6, 2025

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Feb 6, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 6, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2025
@aaythapa aaythapa reopened this Feb 10, 2025
@aaythapa aaythapa added the pr-linter/do-not-close The PR linter will not close this PR while this label is present label Feb 10, 2025
@leonmk-aws leonmk-aws self-assigned this Jun 17, 2025
leonmk-aws
leonmk-aws previously approved these changes Jun 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@leonmk-aws leonmk-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution, I have approved the changes

@mergify mergify bot dismissed leonmk-aws’s stale review June 18, 2025 12:21

Pull request has been modified.

@georeeve georeeve requested a review from leonmk-aws June 18, 2025 12:23
@leonmk-aws leonmk-aws added needs-security-review Related to feature or issues that needs security review and removed closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. needs-security-review Related to feature or issues that needs security review labels Jun 18, 2025
leonmk-aws
leonmk-aws previously requested changes Jun 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@leonmk-aws leonmk-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a merge conflict to resolve and the build is failing (most likely will be solved when resolving the merge conflict)

@mergify mergify bot dismissed leonmk-aws’s stale review June 18, 2025 14:00

Pull request has been modified.

@georeeve georeeve requested a review from leonmk-aws June 18, 2025 15:18
leonmk-aws
leonmk-aws approved these changes Jun 18, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@leonmk-aws leonmk-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, thank you

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Jun 18, 2025

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7764ee6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit aea1372 into aws:main Jun 18, 2025
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@leonmk-aws leonmk-aws leonmk-aws approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

@leonmk-aws leonmk-aws

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/medium Medium work item – several days of effort p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. pr-linter/do-not-close The PR linter will not close this PR while this label is present

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(amplify-alpha): customResponseHeaders does not support monorepo structures

5 participants

@georeeve @aws-cdk-automation @leonmk-aws @aaythapa @samson-keung