Skip to content

chore(lambda-go-alpha): update docker base image#31766

Merged
mergify[bot] merged 8 commits intomainfrom
5d/update-lambda-go-alpha-base-image
Oct 17, 2024
Merged

chore(lambda-go-alpha): update docker base image#31766
mergify[bot] merged 8 commits intomainfrom
5d/update-lambda-go-alpha-base-image

Conversation

@5d
Copy link
Copy Markdown
Member

@5d 5d commented Oct 15, 2024

Issue # (if applicable)

Closes #.

Reason for this change

The build-go image is depracated.

Description of changes

As recommended in this announcement, migrating the base image of aws-lambda-go-alpha integration test dockerfile base image to al2023.

Additionally, an assertion was added to test the lambda function invocation. This is a custom lambda runtime, as previouse comment noted, the aws-lambda-go runtime package is not available.

Description of how you validated changes

  • yarn integ-runner --directory packages/@aws-cdk/aws-lambda-go-alpha

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 15, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 15, 2024 19:53
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Oct 15, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@5d 5d force-pushed the 5d/update-lambda-go-alpha-base-image branch from 859dc3f to 07bd866 Compare October 15, 2024 20:00
@5d 5d changed the title fix(lambda-go-alpha): update docker base image chore(lambda-go-alpha): update docker base image Oct 15, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 15, 2024 20:02

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@5d 5d marked this pull request as ready for review October 15, 2024 22:08
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 15, 2024
@5d 5d force-pushed the 5d/update-lambda-go-alpha-base-image branch 2 times, most recently from cbbdb4c to 0a70f0d Compare October 16, 2024 20:57
@5d 5d force-pushed the 5d/update-lambda-go-alpha-base-image branch from 0a70f0d to d773eb0 Compare October 16, 2024 23:31
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 17, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7cf3a08
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit cf63e90 into main Oct 17, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 17, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the 5d/update-lambda-go-alpha-base-image branch October 17, 2024 11:01
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants