feat(cli): upgrade aws-sdk to sdkv3#31702
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
| const SKIP_TESTS = fs | ||
| .readFileSync(path.join(__dirname, '..', 'skip-tests.txt'), { encoding: 'utf-8' }) |
There was a problem hiding this comment.
…ub.com:aws/aws-cdk into TheRealAmazonKendra/sdkv3-for-aws-cdk-take-two
…s-cdk-take-two' into TheRealAmazonKendra/sdkv3-for-aws-cdk-take-two
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
left a comment
There was a problem hiding this comment.
I trust the construction of this nuclear power plant.
# Conflicts: # packages/@aws-cdk/integ-runner/package.json
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31702 +/- ##
==========================================
- Coverage 77.44% 77.28% -0.17%
==========================================
Files 106 114 +8
Lines 7200 7628 +428
Branches 1345 1360 +15
==========================================
+ Hits 5576 5895 +319
- Misses 1428 1551 +123
+ Partials 196 182 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
This PR updates the CDK CLI to use the AWS SDK V3 instead of V2.
Manual Test Cases for Authorization
All tests were run verbosely so that I could manually check the credentials being used from the CLI output.
--profileandAWS_PROFILEaws_access_key_idandaws_secret_access_keyaws_access_key_idandaws_secret_access_keyandregionsource_profileandrole_arnthat points to another profile withaws_access_key_idandaws_secret_access_keyin both config and credentialssource_profileandrole_arnthat points to Environmentsource_profilethat androle_arnthat points to SSO profile in both config and credentials[profile]and split between[sso-session]and[profile]credential_sourceis Environmentcredential_processaws_access_key_idandaws_secret_access_keyaws_access_key_idandaws_secret_access_keyandregionsource_profileandrole_arnthat points to another profile withaws_access_key_idandaws_secret_access_keyin both config and credentialssource_profileandrole_arnthat points to Environmentsource_profilethat androle_arnthat points to SSO profile in both config and credentialscredential_sourceis Environmentcredential_sourceis EcsContainer (integ tests in CodeBuild)credential_processAWS_ACCESS_KEY_IDandAWS_SECRET_ACCESS_KEYenvironment variables set (cleared after test)AMAZON_ACCESS_KEY_IDandAMAZON_SECRET_ACCESS_KEYenvironment variables set (cleared after test)aws_access_key_idandaws_secret_access_keyaws_access_key_idandaws_secret_access_keyandregionsource_profileandrole_arnthat points to a profile withaws_access_key_idandaws_secret_access_keysource_profileandrole_arnthat points to Environment (this will usefromEnvprior to getting to looking forsource_profilein the Ini file)credential_processMissing cases:
credential_sourceCloses #25870, #26292, #20956, #24744, #27265, 20896.
Reason for this change
The AWS SDK V2 is now in maintenance mode.
***Note: This is now blocked by #31623 because the underlying changes to cdk-assets were not merged to the v3 branch so that will need to be done before this can be rebased and merged.
Additionally, the version will need to be updated for skipping regression tests when this PR is ready to be merged.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license