Skip to content

fix(elasticloadbalancingv2): http2Enabled with true is ignored in ApplicationLoadBalancer#31675

Merged
mergify[bot] merged 4 commits intoaws:mainfrom
go-to-k:elb-http2enabled
Oct 10, 2024
Merged

fix(elasticloadbalancingv2): http2Enabled with true is ignored in ApplicationLoadBalancer#31675
mergify[bot] merged 4 commits intoaws:mainfrom
go-to-k:elb-http2enabled

Conversation

@go-to-k
Copy link
Copy Markdown
Contributor

@go-to-k go-to-k commented Oct 6, 2024 •
edited
Loading

Issue # (if applicable)

Closes #31609.

Reason for this change

The http2Enabled can only be set to CFn if it is specified with false. Therefore, if it is specified with true, the change is not reflected in CFn.

Description of changes

Passed http2Enabled if it is not undefined.

if (props.http2Enabled !== undefined) { this.setAttribute('routing.http2.enabled', props.http2Enabled ? 'true' : 'false'); }

Description of how you validated changes

Both unit and integ tests.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team October 6, 2024 12:31
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Oct 6, 2024
@go-to-k go-to-k changed the title fix(elasticloadbalancingv2): http2Enabled with true is ignored in ApplicationLoadBalancer fix(elasticloadbalancingv2): http2Enabled with true is ignored in ApplicationLoadBalancer Oct 6, 2024
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 6, 2024
badmintoncryer
badmintoncryer approved these changes Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I suggested a refactor comment. This modification is not mandatory, so please feel free to apply it if it suits your preference!

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 8, 2024
@moelasmar moelasmar self-assigned this Oct 8, 2024
moelasmar
moelasmar previously approved these changes Oct 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@moelasmar moelasmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2024
@mergify mergify bot dismissed moelasmar’s stale review October 10, 2024 09:22

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 10, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 10, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4b6a1eb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c1b240e into aws:main Oct 10, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 10, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@badmintoncryer badmintoncryer badmintoncryer approved these changes

@moelasmar moelasmar moelasmar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@moelasmar moelasmar

Labels

bug This issue is a bug. distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ElasticLoadBalancingV2: ApplicationLoadBalancer http2.enabled from false to true is ignored in cloudformation

4 participants

@go-to-k @aws-cdk-automation @badmintoncryer @moelasmar