chore(kinesisfirehose-alpha): replacedestinations property with destination and change type from array to single IDestination#31630
Conversation
…ype from array to single IDestination
destinations property type from array to single IDestination
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
destinations property type from array to single IDestinationdestinations property with destination and change type from array to single IDestination
destinations property with destination and change type from array to single IDestinationdestinations property with destination and change type from array to single IDestination
destinations property with destination and change type from array to single IDestinationdestinations property with destination and change type from array to single IDestination
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Leo10Gama
left a comment
There was a problem hiding this comment.
(it was, in fact, the last)
|
@Mergifyio update |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
☑️ Nothing to doDetails
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Setting a destination for your Delivery Stream was previously done by passing in an array of Destinations but with a restriction that there there could only be one Destination in that array. This property type does not make sense for the current user experience (have an array but can only specify one destination) and also does not align with the behaviour in the AWS Console which only allows you to select a single destination.
If Kinesis Firehose ever supports multiple destinations in the future then we can add a new property to support that which will not be a breaking change.
Description of changes
BREAKING CHANGE: replaced
destinationsproperty withdestination(singular) and changed the type from array of Destinations to a single Destination. Old behaviour would only allow an array with a single Destination to be passed in anyway.Description of how you validated changes
unit tests + no integ snapshot changes.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license