Skip to content

chore: fix failing notices integ test#31625

Merged
mergify[bot] merged 2 commits intomainfrom
epolon/fix-notices-integ
Oct 2, 2024
Merged

chore: fix failing notices integ test#31625
mergify[bot] merged 2 commits intomainfrom
epolon/fix-notices-integ

Conversation

@iliapolo
Copy link
Copy Markdown
Contributor

@iliapolo iliapolo commented Oct 2, 2024

There were two problems:

  1. The test compares against bootstrap stack version 22. This will break once we bump the bootstrap stack version. Changed range to <1999 to include all possible future versions.
  2. The CLI and Framework notices are not displayed because in the pipeline, their version is suffixed with -rc.1, and apparently semver doesn't match against those.

semver.satisfies('2.16.0-rc.0', '<99.0.0') // false
semver.satisfies('2.16.0', '<99.0.0') // true

I don't see a quick way around this so I just removed those notices from the test. We have plenty of unit tests to cover this so i'm not too concerned. Note that this means our notices mechanism isn't able to match against pre-releases, this had always been the case and is ok since we don't publish our pre-releases.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 2, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team October 2, 2024 18:12
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 2, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 2, 2024

➡️ PR build request submitted to test-main-pipeline ⬅️

A maintainer must now check the pipeline and add the pr-linter/cli-integ-tested label once the pipeline succeeds.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 2, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e65f6be
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 0c753c3 into main Oct 2, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 2, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot deleted the epolon/fix-notices-integ branch October 2, 2024 19:32
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 2, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

+1 more reviewer

@sumupitchayan sumupitchayan sumupitchayan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iliapolo @aws-cdk-automation @rix0rrr @sumupitchayan