Skip to content

chore(pipes-targets): update integration tests to use SqsSource#31588

Merged
mergify[bot] merged 8 commits intoaws:mainfrom
msambol:pipes-targets-int-tests
Oct 8, 2024
Merged

chore(pipes-targets): update integration tests to use SqsSource#31588
mergify[bot] merged 8 commits intoaws:mainfrom
msambol:pipes-targets-int-tests

Conversation

@msambol
Copy link
Copy Markdown
Contributor

@msambol msambol commented Sep 28, 2024 •
edited
Loading

This incorporates feedback from #30756 so all integration tests are uniform.

Related to #31589.

@aws-cdk-automation aws-cdk-automation requested a review from a team September 28, 2024 01:33
@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Sep 28, 2024
@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Sep 28, 2024

@moelasmar Could you review this one? As discussed in #30756.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 28, 2024
@msambol msambol mentioned this pull request Sep 28, 2024
Closed
msambol
msambol commented Oct 6, 2024
View reviewed changes
GavinZZ
GavinZZ previously approved these changes Oct 7, 2024
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 7, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 7, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed GavinZZ’s stale review October 8, 2024 01:12

Pull request has been modified.

@msambol
Copy link
Copy Markdown
Contributor Author

msambol commented Oct 8, 2024

@GavinZZ Apologies, had to fix an error that happened during a rebase.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 8, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 8, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 8, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c516efb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit b766a83 into aws:main Oct 8, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mrgrain mrgrain mrgrain approved these changes

+1 more reviewer

@GavinZZ GavinZZ GavinZZ left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msambol @aws-cdk-automation @mrgrain @GavinZZ