Skip to content

feat(elasticloadbalancingv2): support TCP idle timeout for Network Load Balancer Listener#31584

Merged
mergify[bot] merged 9 commits intoaws:mainfrom
mazyu36:nlb-tcp-idle-timeout-31310
Oct 8, 2024
Merged

feat(elasticloadbalancingv2): support TCP idle timeout for Network Load Balancer Listener#31584
mergify[bot] merged 9 commits intoaws:mainfrom
mazyu36:nlb-tcp-idle-timeout-31310

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Sep 27, 2024 •
edited
Loading

Issue # (if applicable)

Closes #31310.

Reason for this change

To set idle timeout for NLB.

AWS Network Load Balancer now supports configurable TCP idle timeout.

Announcement: https://aws.amazon.com/about-aws/whats-new/2024/09/aws-network-load-balancer-tcp-idle-timeout/

Description of changes

  • Add attributes to BaseListener class.
  • Add tcpIdleTimeout property to NetworkListener class.

Description of how you validated changes

Add unit tests and integ test.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Sep 27, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 27, 2024 12:00
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 27, 2024
@mazyu36 mazyu36 marked this pull request as ready for review October 4, 2024 14:58
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 4, 2024
badmintoncryer
badmintoncryer suggested changes Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! I just made one comment.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 8, 2024
@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Oct 8, 2024

@badmintoncryer
Thank you for the review!
I've added a validation and an unit test.

@mazyu36 mazyu36 requested a review from badmintoncryer October 8, 2024 11:31
badmintoncryer
badmintoncryer approved these changes Oct 8, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 8, 2024
@sumupitchayan
Copy link
Copy Markdown
Contributor

sumupitchayan commented Oct 8, 2024

@Mergifyio update

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 8, 2024

update

✅ Branch has been successfully updated

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 8, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 8, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7ef2f73
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 8d851a9 into aws:main Oct 8, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 8, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 8, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2024
@mazyu36 mazyu36 deleted the nlb-tcp-idle-timeout-31310 branch October 8, 2024 23:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@badmintoncryer badmintoncryer badmintoncryer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

aws-elasticloadbalancingv2: support tcp idle timeout for Network Load Balancer

4 participants

@mazyu36 @sumupitchayan @aws-cdk-automation @badmintoncryer