fix(custom-resource-handlers): better fallback for require failures#31571
fix(custom-resource-handlers): better fallback for require failures#31571mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
sumupitchayan
left a comment
There was a problem hiding this comment.
@glitchassassin thanks for the PR, can you check out the build failure? Looks like you may have forgotten to run the integ tests and update the snapshots
|
Thanks @sumupitchayan, @GavinZZ is helping me out with the integration tests |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #30067.
Reason for this change
Fallback to existing AWS SDK import misses a rare/flaky edge case where the npm install passes, but the subsequent
requirefailsDescription of changes
Fall back to the pre-existing AWS SDK if requiring the latest version fails
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license