feat(bedrock): support meta llama3-2#31568
Conversation
sumupitchayan
left a comment
There was a problem hiding this comment.
Thanks for the PR - can you validate these changes by adding these newly supported models to an existing integ test and update the snapshots? Just to confirm that it deploys - also a nit, I think this should be a feat instead of a chore
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Integ tests don't yet appear to exist in the bedrock module, and there is no a directory for bedrock in the @aws-cdk-testing module. What should I do? |
|
Exemption Request: This PR just adds models as enum. |
|
Oh, I found in SFn tasks module! I will add to the test. |
|
Updated and run. |
sumupitchayan
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the test!
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@Mergifyio update |
✅ Branch has been successfully updated |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #.
Reason for this change
Added Meta Llama 3.2 models.
ref
Description of changes
Added the models.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license