chore(rds): deprecate aurora mysql version 1 for mysql 5.6#31551
chore(rds): deprecate aurora mysql version 1 for mysql 5.6#31551mergify[bot] merged 4 commits intoaws:mainfrom
Conversation
| isFromLegacyInstanceProps: true, | ||
| }; | ||
| new rds.DatabaseCluster(stack, 'DualstackCluster', { | ||
| engine: rds.DatabaseClusterEngine.auroraMysql({ version: rds.AuroraMysqlEngineVersion.VER_3_02_0 }), |
There was a problem hiding this comment.
VER_3_02_0 is deprecated.
Only running the integ test before the snapshot update failed, so I deleted the snapshot directory and ran the test.
Cannot find version 8.0.mysql_aurora.3.02.0 for aurora-mysql
|
|
||
| new rds.DatabaseCluster(stack, 'Database', { | ||
| engine: rds.DatabaseClusterEngine.auroraMysql({ | ||
| version: rds.AuroraMysqlEngineVersion.VER_3_01_0, |
There was a problem hiding this comment.
VER_3_01_0 is deprecated.
Only running the integ test before the snapshot update failed, so I deleted the snapshot directory and ran the test.
Cannot find version 8.0.mysql_aurora.3.01.0 for aurora-mysql
| }), | ||
| instances: 3, | ||
| instanceProps: { | ||
| instanceType: ec2.InstanceType.of(ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.SMALL), |
There was a problem hiding this comment.
SMALL cannot be used for Aurora V3, CFn fails with the message:
RDS does not support creating a DB instance with the following combination: DBInstanceClass=db.t3.small, Engine=aurora-mysql, EngineVersion=8.0.mysql_aurora.3.07.1, LicenseModel=general-public-license. For supported combinations of instance class and database engine version, see the documentation.
| username: 'clusteradmin', | ||
| }); | ||
| serverlessCluster = new ServerlessCluster(stack, 'AuroraCluster', { | ||
| engine: DatabaseClusterEngine.auroraMysql({ version: AuroraMysqlEngineVersion.VER_2_07_1 }), |
There was a problem hiding this comment.
VER_2_07_1 is deprecated.
| }); | ||
|
|
||
| new rds.DatabaseCluster(this, 'DatabaseCluster', { | ||
| engine: rds.DatabaseClusterEngine.AURORA, |
There was a problem hiding this comment.
Only running the integ test before the snapshot update failed, so I deleted the snapshot directory and ran the test.
Engine version not found: oscar/null
| version: AuroraPostgresEngineVersion.VER_11_6, | ||
| version: AuroraPostgresEngineVersion.VER_16_3, | ||
| }); | ||
|
|
||
| // WHEN | ||
| const family = engine.parameterGroupFamily; | ||
|
|
||
| // THEN | ||
| expect(family).toEqual('aurora-postgresql11'); |
There was a problem hiding this comment.
While I'm at it: VER_11_6 for PostgreSQL is deprecated.
| const mysqlLogTypes = ['error', 'general', 'slowquery', 'audit']; | ||
| expect(DatabaseClusterEngine.aurora({ version: AuroraEngineVersion.VER_1_22_2 }).supportedLogTypes).toEqual(mysqlLogTypes); | ||
| expect(DatabaseClusterEngine.auroraMysql({ version: AuroraMysqlEngineVersion.VER_2_08_1 }).supportedLogTypes).toEqual(mysqlLogTypes); | ||
| expect(DatabaseClusterEngine.auroraPostgres({ version: AuroraPostgresEngineVersion.VER_9_6_9 }).supportedLogTypes).toEqual(['postgresql']); |
There was a problem hiding this comment.
While I'm at it: VER_9_6_9 for PostgreSQL is deprecated.
| new ServerlessCluster(stack, 'Database', { | ||
| engine: DatabaseClusterEngine.AURORA, | ||
| engine: DatabaseClusterEngine.AURORA_POSTGRESQL, | ||
| parameterGroup: ParameterGroup.fromParameterGroupName(stack, 'ParameterGroup', 'default.aurora-postgresql11'), | ||
| }); |
There was a problem hiding this comment.
Used AURORA_POSTGRESQL because the 'default.aurora-postgresql11' is specified at parameterGroup.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Reason for this change
Aurora MySQL version 1 for MySQL 5.6 is deprecated now.
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraMySQLReleaseNotes/AuroraMySQL.Updates.11Updates.html
Description of changes
Deprecated the version and no longer use the version in integ tests.
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license