chore(ecs): add integ test for ECS with Windows use case#31545
chore(ecs): add integ test for ECS with Windows use case#31545mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| image: ecs.ContainerImage.fromRegistry('public.ecr.aws/aws-observability/aws-for-fluent-bit:windowsservercore-stable'), | ||
| memoryLimitMiB: 2096, | ||
| cpu: 1024, | ||
| }); |
There was a problem hiding this comment.
May be it would be better also to have an assert to make sure we are able to call the containerized application. I think we can have this as separate PR later. What do you think?
There was a problem hiding this comment.
Do you mean calling the containerized application from the outside? If so, the difficulty there is that I couldn't find an image in the ECR registry that 1. expose an endpoint and 2. runs on Windows.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
None
Reason for this change
Adding an integ test of using ECS with Windows AMIs. This is currently missing, hence, is a test gap.
Description of changes
The integ test creates an ECS cluster and a Ec2Service that lives in EC2 instances.
Description of how you validated changes
N/A
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license