Skip to content

fix: update L1 CloudFormation resource definitions by removing outdated schema overrides#31539

Merged
mergify[bot] merged 2 commits intomainfrom
mrgrain/fix/remove-outdated-schema-patches
Sep 24, 2024
Merged

fix: update L1 CloudFormation resource definitions by removing outdated schema overrides#31539
mergify[bot] merged 2 commits intomainfrom
mrgrain/fix/remove-outdated-schema-patches

Conversation

@mrgrain
Copy link
Copy Markdown
Contributor

@mrgrain mrgrain commented Sep 24, 2024 •
edited
Loading

Reason for this change

We didn't receive automated updates for the following three resources since they had a temporary schema override:

AWS::ECS::CapacityProvider
AWS::Lambda::EventSourceMapping
AWS::Lambda::Function

This prevented new features like EventSourceMapping tagging or documentation updates to be applied to the AWS CDK.

Description of changes

Remove the outdated temporary schemas.

Description of how you validated changes

Manually compared that the current schemas from @aws-cdk/awscdk-service-spec are additive compared to the schema overrides. Specifically checked that the features they were added for are now available upstream.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 24, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 24, 2024 08:48
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 24, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Sep 24, 2024
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 24, 2024 08:52

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 24, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 25e73e5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 24, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 218331b into main Sep 24, 2024
@mergify mergify bot deleted the mrgrain/fix/remove-outdated-schema-patches branch September 24, 2024 09:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 24, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@iliapolo iliapolo iliapolo approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mrgrain @aws-cdk-automation @iliapolo