Skip to content

chore(ec2): add SageMaker Interface VPC Endpoint#31538

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
KawaiHaruki:addVPCendpoint
Oct 3, 2024
Merged

chore(ec2): add SageMaker Interface VPC Endpoint#31538
mergify[bot] merged 3 commits intoaws:mainfrom
KawaiHaruki:addVPCendpoint

Conversation

@KawaiHaruki
Copy link
Copy Markdown
Contributor

@KawaiHaruki KawaiHaruki commented Sep 24, 2024

Issue # (if applicable)

None.

Reason for this change

SageMaker Experiments supports private link access but AWS CDK does not support creating an interface VPC endpoint for SageMaker Experiments.

Description of changes

Add Interface VPC Endpoint for AWS SageMaker Experiments.

Description of how you validated changes

I executed the AWS CLI command as shown below.

$ aws ec2 describe-vpc-endpoint-services --filters Name=service-type,Values=Interface Name=owner,Values=amazon --region us-east-1 --query ServiceNames | grep sagemaker
    "aws.sagemaker.us-east-1.experiments", // added
    "aws.sagemaker.us-east-1.notebook",
    "aws.sagemaker.us-east-1.studio",
    "com.amazonaws.us-east-1.sagemaker.api",
    "com.amazonaws.us-east-1.sagemaker.featurestore-runtime",
    "com.amazonaws.us-east-1.sagemaker.metrics",
    "com.amazonaws.us-east-1.sagemaker.runtime",
    "com.amazonaws.us-east-1.sagemaker.runtime-fips",

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team September 24, 2024 07:39
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Sep 24, 2024
badmintoncryer
badmintoncryer approved these changes Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@badmintoncryer badmintoncryer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

@badmintoncryer
Copy link
Copy Markdown
Contributor

badmintoncryer commented Sep 24, 2024

@KawaiHaruki Could you please merge the main branch to your feature branch?

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 30, 2024
sumupitchayan
sumupitchayan previously approved these changes Oct 3, 2024
View reviewed changes
@mergify mergify bot dismissed sumupitchayan’s stale review October 3, 2024 14:39

Pull request has been modified.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Oct 3, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 57af312
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 3, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 7a4f865 into aws:main Oct 3, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 3, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@sumupitchayan sumupitchayan sumupitchayan approved these changes

@badmintoncryer badmintoncryer badmintoncryer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-maintainer-review This PR needs a review from a Core Team Member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@KawaiHaruki @badmintoncryer @aws-cdk-automation @sumupitchayan