Skip to content

feat(logs): add metric methods for log group IncomingLogEvents and IncomingBytes#31535

Merged
mergify[bot] merged 10 commits intoaws:mainfrom
michelle-wangg:aws-logs-metrics
Sep 25, 2024
Merged

feat(logs): add metric methods for log group IncomingLogEvents and IncomingBytes#31535
mergify[bot] merged 10 commits intoaws:mainfrom
michelle-wangg:aws-logs-metrics

Conversation

@michelle-wangg
Copy link
Copy Markdown
Contributor

@michelle-wangg michelle-wangg commented Sep 23, 2024 •
edited
Loading

Issue

Closes #30034

Reason for this change

  • Create alarms on log ingestion to ensure it is working

Description of changes

  • Add metric methods for log group IncomingLogEvents and IncomingBytes, similar to existing metric methods like metricInvocations on Lambda functions.

Description of how you validated changes

  • validated with new unit tests and a new integration test

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 23, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team September 23, 2024 18:45
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 23, 2024
aws-cdk-automation
aws-cdk-automation previously requested changes Sep 23, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. labels Sep 23, 2024
@michelle-wangg michelle-wangg changed the title feat(aws-logs): add metric methods for log group IncomingLogEvents and IncomingBytes feat(logs): add metric methods for log group IncomingLogEvents and IncomingBytes Sep 23, 2024
@michelle-wangg michelle-wangg force-pushed the aws-logs-metrics branch 2 times, most recently from c648bf5 to 5191620 Compare September 23, 2024 22:57
@aws-cdk-automation aws-cdk-automation dismissed their stale review September 24, 2024 00:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@github-advanced-security
Copy link
Copy Markdown

github-advanced-security bot commented Sep 24, 2024

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@michelle-wangg michelle-wangg marked this pull request as ready for review September 24, 2024 17:53
GavinZZ
GavinZZ reviewed Sep 24, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Left some comments.

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 24, 2024
GavinZZ
GavinZZ reviewed Sep 25, 2024
View reviewed changes
packages/aws-cdk-lib/aws-logs/lib/log-group.ts Outdated
* - 'IncomingLogEvents': The number of log events ingested into the log group.
* ```
*/
public metric(_metricName: string, _props?: cloudwatch.MetricOptions): cloudwatch.Metric {
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public metric(_metricName: string, _props?: cloudwatch.MetricOptions): cloudwatch.Metric {
public metric(metricName: string, props?: cloudwatch.MetricOptions): cloudwatch.Metric {

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Sep 25, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

aws-cdk-automation commented Sep 25, 2024

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 451f2ab
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 2813eb2 into aws:main Sep 25, 2024
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 25, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Sep 25, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

+1 more reviewer

@GavinZZ GavinZZ GavinZZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-logs): Add metric methods for log group IncomingLogEvents and IncomingBytes

4 participants

@michelle-wangg @github-advanced-security @aws-cdk-automation @GavinZZ